OpenAPI SLO specification changes#161922
Merged
wandergeek merged 11 commits intomainfrom Jul 15, 2023
Merged
Conversation
wandergeek
added
the
Team:Observability
Contributor
|
Pinging @elastic/unified-observability (Team:Observability) |
kdelemme
reviewed
Jul 14, 2023
Contributor
kdelemme
left a comment
kdelemme
left a comment
There was a problem hiding this comment.
One missing indicator and one type in the the discriminator mapping, otherwise it looks good to me! Thanks for making this
…as/slo_response.yaml Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
wandergeek
added
the
release_note:skip
kdelemme
approved these changes
Jul 15, 2023
Contributor
kdelemme
left a comment
kdelemme
left a comment
There was a problem hiding this comment.
Just need to fix the Makefile issue, either rename or remove
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @wandergeek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a few changes to the openAPI specification for the SLO API to assist in the generation of Golang clients and models.
This PR accomplishes the following:
indicatorIDs to prevent naming conflicts in the generated clientsummary_statusschema which is used in multiple placesRel: https://elasticco.atlassian.net/jira/software/c/projects/O11Y/issues/O11Y-236?filter=myopenissues